feat: create shadow theme #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouji-miyahara
requested review from
diescake and
Tokky0425
and removed request for
a team
|
Deploy preview for smarthr-ui ready! Built with commit 0c43d92 |
nabeliwo
reviewed
Sep 25, 2020
Comment on lines
+4
to
+5
| BASE?: string | ||
| DIALOG?: string |
There was a problem hiding this comment.
[ask] SmartHR Design の「影」の項目を見た感じだとここらへんのキーはまだ WIP なのかなと思ったのですが、今回の BASE, DIALOG っていうのは一時的にって感じでしょうか？
There was a problem hiding this comment.
@nabeliwo 現時点でもデザインとのブレがあるので、まずは定数を使いたくてキーは一時的に設定しておりますー 🙏
|
|
||
| interface ThemeProperty { | ||
| palette?: PaletteProperty | ||
| size?: SizeProperty | ||
| frame?: FrameProperty | ||
| interaction?: InteractionProperty | ||
| shadow?: ShadowProperty |
There was a problem hiding this comment.
[nits] 今回対応してほしい、みたいな話じゃないですが、 frame と shadow って一つにまとめて別の名前を当てられないかな〜ってちょっと思いました
There was a problem hiding this comment.
あー、そこまで考えてなかったっす。いちど定例あたりで相談できますとー
nabeliwo
previously approved these changes
Oct 5, 2020
nabeliwo
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related URL
Overview
What I did
src/themes/createShadow.tsを追加Capture