Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change storybook addon order #1041

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

kgsi
Copy link
Contributor

@kgsi kgsi commented Oct 5, 2020

Related URL

https://smarthr.atlassian.net/jira/software/projects/SHRUI/boards/99?selectedIssue=SHRUI-139

Overview

  • READMEタブがdefaultで一番最初に表示されるように変更したい

What I did

  • addons内の読み込み順をreadmeが一番最初になるように変更

@kgsi kgsi requested a review from a team as a code owner October 5, 2020 05:16
@kgsi kgsi requested review from diescake and zoshigayan and removed request for a team October 5, 2020 05:16
@netlify
Copy link

netlify bot commented Oct 5, 2020

Deploy preview for smarthr-ui ready!

Built with commit 39cbf6a

https://deploy-preview-1041--smarthr-ui.netlify.app

@kgsi kgsi changed the title feat: change addon order feat: change storybook addon order Oct 5, 2020
Copy link
Contributor

@diescake diescake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

めっちゃ便利だ… LGTM です!! 🎉 🎉

Copy link
Contributor

@zoshigayan zoshigayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最高だぁ ありがとうございます

@kgsi kgsi merged commit 29bde4c into kufu:master Oct 7, 2020
@kgsi
Copy link
Contributor Author

kgsi commented Oct 7, 2020

わーい、マージしました:tada:

@wmoai wmoai mentioned this pull request Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants