Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: TextのVRT用Storyを追加 #3999

Merged
merged 1 commit into from
Nov 15, 2023
Merged

chore: TextのVRT用Storyを追加 #3999

merged 1 commit into from
Nov 15, 2023

Conversation

tomof
Copy link
Contributor

@tomof tomof commented Nov 15, 2023

Overview

TextコンポーネントにVRT用のStoryを追加しました。

What I did

  • Forced Colors
    • forcedColors: 'active' を適用した状態

これもHeading同様に単純にテキストだけなのでForced ColorsでさえもVRTが必要か悩ましかったので、不要であればリジェクトでも構いません!🙏
他に必要そうなストーリーがあればご指摘ください。

Capture

Forced Colors

image

@tomof tomof self-assigned this Nov 15, 2023
@tomof tomof requested a review from a team as a code owner November 15, 2023 05:54
@tomof tomof requested review from AtsushiM and 8tako8tako8 and removed request for a team November 15, 2023 05:54
Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for smarthr-ui ready!

Name Link
🔨 Latest commit 092292a
🔍 Latest deploy log https://app.netlify.com/sites/smarthr-ui/deploys/65545d23d08ebd0008d2e608
😎 Deploy Preview https://deploy-preview-3999--smarthr-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@uknmr uknmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@uknmr uknmr merged commit cfde2d9 into master Nov 15, 2023
13 checks passed
@uknmr uknmr deleted the chore-add-vrt-text branch November 15, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants