Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icon): Add a FaEye icon #420

Merged
merged 1 commit into from
Oct 28, 2019
Merged

feat(icon): Add a FaEye icon #420

merged 1 commit into from
Oct 28, 2019

Conversation

meganemura
Copy link
Member

image

@meganemura meganemura requested a review from a team as a code owner October 28, 2019 03:01
@ghost ghost requested review from nabeliwo and removed request for a team October 28, 2019 03:01
@reg-suit
Copy link

reg-suit bot commented Oct 28, 2019

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

nabeliwo
nabeliwo approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@nabeliwo nabeliwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meganemura
Copy link
Member Author

🤗

@meganemura meganemura merged commit c3f5322 into features/ttmz Oct 28, 2019
@meganemura meganemura deleted the icon-eye branch October 28, 2019 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabeliwo nabeliwo nabeliwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meganemura @nabeliwo