Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change component name #425

Merged
merged 7 commits into from
Oct 31, 2019
Merged

Change component name #425

merged 7 commits into from
Oct 31, 2019

Conversation

nabeliwo
Copy link
Member

  • Flash -> FlashMessage
  • Checkbox -> CheckBox
  • CheckboxLabel -> CheckBoxLabel
  • Radio -> RadioButton
  • RadioLabel -> RadioButtonLabel
  • Tag -> StatusLabel

@nabeliwo nabeliwo requested a review from a team as a code owner October 31, 2019 05:42
@ghost ghost requested review from cidermitaina and removed request for a team October 31, 2019 05:42
@nabeliwo nabeliwo mentioned this pull request Oct 31, 2019
Closed
@nabeliwo nabeliwo requested review from im36-123 and removed request for cidermitaina October 31, 2019 05:43
im36-123
im36-123 requested changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@im36-123 im36-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.
Some errors occurred.

The file and directory name needs to be changed.

src/components/Checkbox/Checkbox.* -> src/components/CheckBox/CheckBox.*
src/components/CheckboxLabel/CheckboxLabel.tsx -> src/components/CheckBoxLabel/CheckBoxLabel.*

@nabeliwo
Copy link
Member Author

The file with the error is modified and committed, but CircleCI doesn't seem to recognize it...
(https://github.com/kufu/smarthr-ui/pull/425/files#diff-2d2dd2d30d83000db2f11d926cf7bda3)

I will investigate.

@reg-suit
Copy link

reg-suit bot commented Oct 31, 2019

reg-suit detected visual differences.

Check this report, and review them.

⚪⚪⚪⚪⚪⚪
⚫⚫⚫⚫⚫⚫
🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@im36-123 im36-123 self-requested a review October 31, 2019 06:55
im36-123
im36-123 approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@im36-123 im36-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@nabeliwo nabeliwo merged commit 40d6ae3 into features/ttmz Oct 31, 2019
@nabeliwo nabeliwo deleted the change-component-name branch October 31, 2019 06:57
@nabeliwo nabeliwo mentioned this pull request Oct 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@im36-123 im36-123 im36-123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nabeliwo @im36-123