Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add togglable option in InformationPanel #817

Merged
merged 3 commits into from
Jun 5, 2020
Merged

Conversation

wmoai
Copy link
Contributor

@wmoai wmoai commented Jun 1, 2020

Adding option that can choose showing a toggle button or not in InformationPanel.

@wmoai wmoai requested a review from a team as a code owner June 1, 2020 07:07
@wmoai wmoai self-assigned this Jun 1, 2020
@reg-suit
Copy link

reg-suit bot commented Jun 1, 2020

reg-suit detected visual differences.

Check this report, and review them.

🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@wmoai wmoai requested review from cidermitaina and removed request for a team June 1, 2020 07:07
@netlify
Copy link

netlify bot commented Jun 1, 2020

Deploy preview for smarthr-ui ready!

Built with commit 14ff80f

https://deploy-preview-817--smarthr-ui.netlify.app

@wmoai wmoai changed the title feat: add togglable option in InformationPanel [WIP] feat: add togglable option in InformationPanel Jun 1, 2020
@wmoai wmoai changed the title [WIP] feat: add togglable option in InformationPanel feat: add togglable option in InformationPanel Jun 1, 2020
Copy link
Member

@cidermitaina cidermitaina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!
LGTM🎉

@wmoai wmoai requested a review from cidermitaina June 4, 2020 03:44
@wmoai wmoai merged commit 5df6953 into master Jun 5, 2020
@wmoai wmoai deleted the add-togglable-option branch June 5, 2020 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants