Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wrap-aware line heights #26

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Conversation

StevenEWright
Copy link
Contributor

@StevenEWright StevenEWright commented Aug 15, 2023

This change leverages the new line metrics in the last PR to make highlights and the gutter respect wrapped line in the editor properly.

It also introduces a more powerful highlighting API.

Calling .createHighlight() on the editor now produces a reactive highlight object:

export interface Highlight {
  /** The line number to highlight. */
  get lineNumber(): number;
  set lineNumber(lineNumber: number);

  /** Whether or not the highlight is visible. */
  get visible(): boolean;
  set visible(visible: boolean);

  /** The CSS class to apply to the highlight. */
  get cssClass(): string;
  set cssClass(cssClass: string);

  /** Deletes the highlight. */
  delete(): void;
}

Shown all together:

image

**Github Issue List: ** closes #18

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
  • I Steven E Wright agree to the Developer Certificate of Origin
  • I have reviewed the License Agreement at
    LICENSE.md

Signed-off-by: Steven E Wright <StevenEWright@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Aug 15, 2023

size-limit report 📦

Path Size
./dist/kullna-editor.min.js 7.03 KB (+4.91% 🔺)

Signed-off-by: Steven E Wright <StevenEWright@users.noreply.github.com>
@StevenEWright StevenEWright merged commit 6cccd52 into main Aug 15, 2023
3 checks passed
@StevenEWright StevenEWright deleted the swright/gutters_and_highlights branch August 15, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight Line APIs
1 participant