Enable strict enforcement of signedness constraints #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integers in tenyr are 32-bit signed numbers by default. Much of the code in this implementation of tenyr, however, has used `uint32_t` often, where `int32_t` would be more semantically correct. `UWord` in the object format was left alone, for now, although a case could be made for standardizing on `SWord` there, too.
This could be considered a breaking change to object version 2, but we are not at tenyr v1.0.0 yet, and nobody has objects that are large enough to matter. "Thirty-one bits should be enough for anyone." The "toolong" test case was updated to use the maximum signed 32-bit size instead of the maximum unsigned 32-bit size.
Codecov Report
@@ Coverage Diff @@
## develop #42 +/- ##
========================================
Coverage 87.39% 87.39%
========================================
Files 34 34
Lines 2817 2817
Branches 508 508
========================================
Hits 2462 2462
Misses 186 186
Partials 169 169 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same vein as #39, we enable
-Werror=sign-conversionenforcement, and standardize on signed numbers where possible, even where negative numbers are not particularly meaningful, to avoid problems with integer promotion rules and to simplify the mental model