perf(compiler): remove writing and reading compile output with file system, relies on jest cache #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4522
💛 - Coveralls |
kulshekhar
approved these changes
Apr 24, 2020
ahnpnl
added a commit
that referenced
this pull request
Apr 27, 2020
ahnpnl
added a commit
that referenced
this pull request
Apr 27, 2020
ahnpnl
added a commit
that referenced
this pull request
Apr 28, 2020
ahnpnl
added a commit
that referenced
this pull request
Apr 29, 2020
ahnpnl
added a commit
that referenced
this pull request
Apr 29, 2020
ahnpnl
added a commit
that referenced
this pull request
Apr 30, 2020
ahnpnl
added a commit
that referenced
this pull request
May 1, 2020
ahnpnl
added a commit
that referenced
this pull request
May 1, 2020
ahnpnl
added a commit
that referenced
this pull request
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Writing and reading compile output with file system is not needed for us. We can rely on
jestcaching mechanism.I tested and we can gain 5%-10% on a large set of tests. However, it is very hard to notice.
Related to #1115
Test plan
Green CI
Does this PR introduce a breaking change?
Other information
N.A.