Protecting page will throw exception

[gslin]

In MediaWiki 1.31 (PHP 7.2), when we try to protect a page, it will throw exception:

Backtrace:

#0 /srv/wiki.plurk.info/public/includes/Hooks.php(177): SlackNotifications::slack_article_protected(WikiPage, User, array, string)
#1 /srv/wiki.plurk.info/public/includes/Hooks.php(205): Hooks::callHook(string, array, array, NULL)
#2 /srv/wiki.plurk.info/public/includes/page/WikiPage.php(2521): Hooks::run(string, array)
#3 /srv/wiki.plurk.info/public/includes/page/Article.php(2593): WikiPage->doUpdateRestrictions(array, array, boolean, string, User)
#4 /srv/wiki.plurk.info/public/includes/ProtectionForm.php(312): Article->doUpdateRestrictions(array, array, boolean, string, User)
#5 /srv/wiki.plurk.info/public/includes/ProtectionForm.php(187): ProtectionForm->save()
#6 /srv/wiki.plurk.info/public/includes/page/Article.php(1544): ProtectionForm->execute()
#7 /srv/wiki.plurk.info/public/includes/actions/ProtectAction.php(52): Article->protect()
#8 /srv/wiki.plurk.info/public/includes/MediaWiki.php(500): ProtectAction->show()
#9 /srv/wiki.plurk.info/public/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#10 /srv/wiki.plurk.info/public/includes/MediaWiki.php(861): MediaWiki->performRequest()
#11 /srv/wiki.plurk.info/public/includes/MediaWiki.php(524): MediaWiki->main()
#12 /srv/wiki.plurk.info/public/index.php(42): MediaWiki->run()
#13 {main}

[kulttuuri]

Does this happen only when protecting a page or also with some other hooks (moving a page, removing a page, editing a page...)? to 16.8.2018 klo 7.39 Gea-Suan Lin <notifications@github.com> kirjoitti:

In MediaWiki 1.31 (PHP 7.2), when we try to protect a page, it will throw exception: Backtrace: #0 /srv/wiki.plurk.info/public/includes/Hooks.php(177): SlackNotifications::slack_article_protected(WikiPage, User, array, string) #1 /srv/wiki.plurk.info/public/includes/Hooks.php(205): Hooks::callHook(string, array, array, NULL) #2 /srv/wiki.plurk.info/public/includes/page/WikiPage.php(2521): Hooks::run(string, array) #3 /srv/wiki.plurk.info/public/includes/page/Article.php(2593): WikiPage->doUpdateRestrictions(array, array, boolean, string, User) #4 /srv/wiki.plurk.info/public/includes/ProtectionForm.php(312): Article->doUpdateRestrictions(array, array, boolean, string, User) #5 /srv/wiki.plurk.info/public/includes/ProtectionForm.php(187): ProtectionForm->save() #6 /srv/wiki.plurk.info/public/includes/page/Article.php(1544): ProtectionForm->execute() #7 /srv/wiki.plurk.info/public/includes/actions/ProtectAction.php(52): Article->protect() #8 /srv/wiki.plurk.info/public/includes/MediaWiki.php(500): ProtectAction->show() #9 /srv/wiki.plurk.info/public/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title) #10 /srv/wiki.plurk.info/public/includes/MediaWiki.php(861): MediaWiki->performRequest() #11 /srv/wiki.plurk.info/public/includes/MediaWiki.php(524): MediaWiki->main() #12 /srv/wiki.plurk.info/public/index.php(42): MediaWiki->run() #13 {main} — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#30>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADokdpGwMKuq6poTDq_OqYUw_S5pb59Xks5uRPebgaJpZM4V_MFA> .

-- Sent from my Iphone. Misspellings are subject to my mobile device =)

[gslin]

Currently only protecting page (in my environment) will cause this exception.

btw, I noticed that push_slack_notify() in slack_article_protected() also has problem:

                self::push_slack_notify($message, $user);

And function push_slack_notify() is:

        static function push_slack_notify($message, $bgColor, $user)

Thanks,

[kulttuuri]

Good catch on that function call! I've changed couple lines of code, can you check if it still throws the error?

[gslin]

Thanks, it works now :-)

[kulttuuri]

Fantastic! Closing :)