Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete 'BootstrapVersion' field from BootstrapRequest #2986

Closed
lobkovilya opened this issue Oct 21, 2021 · 1 comment · Fixed by #3670
Closed

Delete 'BootstrapVersion' field from BootstrapRequest #2986

lobkovilya opened this issue Oct 21, 2021 · 1 comment · Fixed by #3670
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it triage/stale Inactive for some time. It will be triaged again

Comments

@lobkovilya
Copy link
Contributor

Summary

After the update to Envoy 1.20 we got rid of the support of the bootstrap version. But the field BootstrapVersion is left in the BootstrapRequest, so new kuma-dp could request an old kuma-cp.

The current issue aims to track TODOs:

  • delete BootstrapVersion field from BootstrapRequest
  • delete deprecated kuma-dp CLI flag --bootstrap-version
@lobkovilya lobkovilya mentioned this issue Oct 21, 2021
Merged
6 tasks
@lahabana lahabana added code-quality kind/cleanup Cleanup/refactor an existing component/code and removed code-quality labels Nov 16, 2021
@lahabana lahabana added the triage/accepted The issue was reviewed and is complete enough to start working on it label Nov 29, 2021
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 30, 2021
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

tharun208 added a commit to tharun208/kuma that referenced this issue Jan 7, 2022
@tharun208
chore(kuma-dp): cleanup bootstrap version field
9075dc8 
Fixes kumahq#2986

Signed-off-by: Tharun <rajendrantharun@live.com>
@tharun208 tharun208 mentioned this issue Jan 7, 2022
Merged
7 tasks
tharun208 added a commit to tharun208/kuma that referenced this issue Mar 7, 2022
@tharun208
chore(kuma-dp): cleanup bootstrap version field
e91230c 
Fixes kumahq#2986

Signed-off-by: Tharun <rajendrantharun@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it triage/stale Inactive for some time. It will be triaged again
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(kuma-dp): cleanup bootstrap version field tharun208/kuma
2 participants
@lahabana @lobkovilya