Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kuma-cp) refactor MatchedPolicies structure #3461

Merged
merged 6 commits into from
Dec 15, 2021
Merged

chore(kuma-cp) refactor MatchedPolicies structure #3461

merged 6 commits into from
Dec 15, 2021

Conversation

lobkovilya
Copy link
Contributor

Summary

Refactor MatchedPolicies type to consist of fields of a similar format. Allowed format:

FIELD is <VALUE> or map[<KEY>]<VALUE> 
KEY is InboundInterface | OutboundInterface | ServiceName 
VALUE is  Resource | []Resource

Tooling is going to rely on that, that's why there is a runtime type validation inside init method.

Full changelog

  • validate MatchedPolicies type at runtime
  • refactor type to the format

Issues resolved

N/A

Documentation

  • internal change, no need for docs

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take
    when upgrading.
  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@lobkovilya
fix(kuma-dp) refactor matched policies
986cac1 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
merge
45134d6 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore(*) make check
0872bde 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore(*) fix unit tests
c78e57c 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner December 9, 2021 15:54
@lobkovilya lobkovilya mentioned this pull request Dec 9, 2021
Merged
7 tasks
@lobkovilya
chore(*): get rid of runtime validation using 'reflect'
147894a 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lahabana lahabana linked an issue Dec 13, 2021 that may be closed by this pull request
Tools for visibility: See all policies that impact a dp #3460
Closed
lahabana
lahabana approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM it's bringing some coherency! :)

pkg/core/resources/apis/mesh/mesh_helpers.go Show resolved Hide resolved
pkg/core/logs/matcher.go Show resolved Hide resolved
@lobkovilya
feat(kuma-cp): add log lines if backend is not found
09fedce 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya merged commit abc8a69 into master Dec 15, 2021
@lobkovilya lobkovilya deleted the chore/refactor-matched-policies branch December 15, 2021 14:59
mergify bot pushed a commit that referenced this pull request Dec 15, 2021
@lobkovilya
chore(kuma-cp) refactor MatchedPolicies structure (#3461)
b56d7bb 
(cherry picked from commit abc8a69)

# Conflicts:
#	pkg/plugins/runtime/gateway/filter_chain_generator.go
@mergify mergify bot mentioned this pull request Dec 15, 2021
Closed
@michaelbeaumont michaelbeaumont mentioned this pull request Dec 15, 2021
Merged
michaelbeaumont added a commit that referenced this pull request Dec 15, 2021
@michaelbeaumont
chore(gateway): fix gateway FilterChain after MatchedPolicies refactor (
1b3aaa0 
#3547)

#3461 was out of date and didn't have #3484

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tools for visibility: See all policies that impact a dp
3 participants
@lobkovilya @lahabana @jakubdyszkiewicz