Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): add prefix to app label in ingress/egress deployment #4123

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Apr 5, 2022

This was missing when using a kuma.name in the template

Signed-off-by: Charly Molter charly.molter@konghq.com

@lahabana lahabana requested a review from a team as a code owner April 5, 2022 08:25
@lahabana
Copy link
Contributor Author

lahabana commented Apr 5, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2022

update

✅ Branch has been successfully updated

@lahabana lahabana enabled auto-merge (squash) April 5, 2022 08:39
This was missing when using a `kuma.name` in the template

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Signed-off-by: Charly Molter <charly.molter@konghq.com>
@codecov-commenter
Copy link

Codecov Report

Merging #4123 (bc7dec8) into master (b95caba) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4123      +/-   ##
==========================================
+ Coverage   55.80%   55.82%   +0.01%     
==========================================
  Files         931      931              
  Lines       56146    56146              
==========================================
+ Hits        31332    31341       +9     
+ Misses      22330    22324       -6     
+ Partials     2484     2481       -3     
Impacted Files Coverage Δ
pkg/core/resources/model/rest/resource.go 71.60% <0.00%> (-1.24%) ⬇️
pkg/core/resources/manager/cache.go 88.31% <0.00%> (+2.59%) ⬆️
pkg/defaults/components.go 88.88% <0.00%> (+3.70%) ⬆️
pkg/plugins/runtime/gateway/route/sorter.go 71.79% <0.00%> (+5.12%) ⬆️
pkg/kds/client/sink.go 59.45% <0.00%> (+5.40%) ⬆️
pkg/test/grpc/clientstream.go 92.00% <0.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b95caba...bc7dec8. Read the comment docs.

@lahabana lahabana merged commit f3c22bc into kumahq:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants