Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): remove flag '--experimental-meshgateway' #4315

Merged
merged 6 commits into from
May 23, 2022

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented May 20, 2022

Summary

Remove flag --experimental-meshgateway

Full changelog

  • [Implement ...]
  • [Fix ...]

Issues resolved

Fix #4263

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner May 20, 2022 11:09
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #4315 (d4692f7) into master (f4f76eb) will decrease coverage by 0.00%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##           master    #4315      +/-   ##
==========================================
- Coverage   55.41%   55.41%   -0.01%     
==========================================
  Files         941      941              
  Lines       57074    57063      -11     
==========================================
- Hits        31630    31621       -9     
+ Misses      22938    22935       -3     
- Partials     2506     2507       +1     
Impacted Files Coverage Δ
pkg/config/app/kuma-cp/config.go 52.44% <ø> (+0.39%) ⬆️
pkg/plugins/runtime/gateway/plugin.go 90.00% <0.00%> (-5.46%) ⬇️
pkg/plugins/runtime/k8s/plugin_gateway.go 0.00% <ø> (ø)
...d/install/context/install_control_plane_context.go 95.55% <100.00%> (-0.19%) ⬇️
...umactl/cmd/install/context/install_crds_context.go 87.50% <100.00%> (+0.83%) ⬆️
app/kumactl/cmd/install/install_control_plane.go 73.10% <100.00%> (ø)
app/kumactl/cmd/install/install_crds.go 30.35% <100.00%> (+1.26%) ⬆️
.../resources/k8s/native/api/v1alpha1/mesh_gateway.go 100.00% <100.00%> (ø)
pkg/defaults/mesh.go 64.28% <0.00%> (-14.29%) ⬇️
...s/authn/api-server/tokens/admin_token_bootstrap.go 82.00% <0.00%> (-4.00%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4f76eb...d4692f7. Read the comment docs.

Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things missing here with helm.sh and MeshGatewayConfig, I'm taking a look

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the chore/remove-experimental-meshgateway branch from 0ce5c41 to 4568da9 Compare May 23, 2022 07:51
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	app/kumactl/cmd/install/testdata/install-control-plane.cni-enabled.golden.yaml
#	app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml
#	app/kumactl/cmd/install/testdata/install-control-plane.global.golden.yaml
#	app/kumactl/cmd/install/testdata/install-control-plane.override-env-vars.golden.yaml
#	app/kumactl/cmd/install/testdata/install-control-plane.with-egress.golden.yaml
#	app/kumactl/cmd/install/testdata/install-control-plane.with-helm-set.yaml
#	app/kumactl/cmd/install/testdata/install-control-plane.with-helm-values.yaml
#	app/kumactl/cmd/install/testdata/install-control-plane.with-ingress.golden.yaml
#	app/kumactl/cmd/install/testdata/install-control-plane.zone.golden.yaml
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@michaelbeaumont
Copy link
Contributor

Maybe @jakubdyszkiewicz can take another look at my changes

@lobkovilya lobkovilya merged commit 1f12a16 into master May 23, 2022
@lobkovilya lobkovilya deleted the chore/remove-experimental-meshgateway branch May 23, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builtin gateway still experimental but enabled by default
4 participants