feat(gateway): propagate x-kuma-tags from MeshGateways #4476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
lahabana
reviewed
Jun 16, 2022
There was a problem hiding this comment.
I think it makes sense wondering if @lukidzi or @jakubdyszkiewicz have an opinion
jakubdyszkiewicz
approved these changes
Jun 20, 2022
|
This is only used for fault injection at this moment and I think it should be eventually removed in favor of reading tags from the cert on the server side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3313
This PR adds
requestHeadersToAddto the weighted clusters depending on if the request is staying in the mesh.The issue assumes we have to do this in RouteConfiguration but it seems like we can add this to each WeightedCluster. Is this (i.e. the configs in the test) the correct behavior?