Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): support GC service account #4483

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Conversation

lobkovilya
Copy link
Contributor

Summary

Special treatment for GC service account when checking if an operation on resources is allowed

Full changelog

  • [Implement ...]
  • [Fix ...]

Issues resolved

Fix #4434

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Update UPGRADE.md with any steps users will need to take when upgrading.
  • Add backport-to-stable label if the code follows our backporting policy

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner June 16, 2022 12:44
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #4483 (fa2dba4) into master (a066dca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4483   +/-   ##
=======================================
  Coverage   55.43%   55.44%           
=======================================
  Files         947      947           
  Lines       58052    58053    +1     
=======================================
+ Hits        32184    32190    +6     
+ Misses      23320    23319    -1     
+ Partials     2548     2544    -4     
Impacted Files Coverage Δ
pkg/plugins/runtime/k8s/webhooks/validation.go 86.06% <100.00%> (+0.11%) ⬆️
pkg/core/resources/manager/cache.go 85.71% <0.00%> (-2.60%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 89.65% <0.00%> (-1.15%) ⬇️
pkg/core/secrets/manager/global_manager.go 42.42% <0.00%> (+3.03%) ⬆️
...s/authn/api-server/tokens/admin_token_bootstrap.go 86.00% <0.00%> (+4.00%) ⬆️
pkg/core/tokens/signing_key_manager.go 90.00% <0.00%> (+5.00%) ⬆️
pkg/core/tokens/default_signing_key.go 77.77% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a066dca...fa2dba4. Read the comment docs.

@lobkovilya lobkovilya merged commit 7ff0c15 into master Jun 21, 2022
@lobkovilya lobkovilya deleted the fix/gc-service-account branch June 21, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kuma Delete Zone doesn't delete dataplanes from this zone.
3 participants