Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): don't deploy Pod/Service webhooks in global #4673

Merged

Conversation

michaelbeaumont
Copy link
Contributor

Summary

Is there a reason to keep them?

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner July 26, 2022 07:48
@codecov-commenter
Copy link

Codecov Report

Merging #4673 (3428b1c) into master (07115e7) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4673   +/-   ##
=======================================
  Coverage   46.45%   46.46%           
=======================================
  Files         684      684           
  Lines       46466    46466           
=======================================
+ Hits        21587    21590    +3     
+ Misses      22964    22962    -2     
+ Partials     1915     1914    -1     
Impacted Files Coverage Δ
pkg/xds/cache/once/cache.go 94.87% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07115e7...3428b1c. Read the comment docs.

@michaelbeaumont michaelbeaumont merged commit 551c6ae into kumahq:master Jul 26, 2022
@michaelbeaumont michaelbeaumont deleted the fix/global_k8s_webhooks branch July 26, 2022 10:33
@michaelbeaumont michaelbeaumont mentioned this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants