-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): build rule-based view #5000
Conversation
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need a second round of review here but so far I did not find anything major that needed to be changed.
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is quite complex but the problem is also not trivial. One question about panic
and one nitpick but otherwise I don't see anything obviously wrong here. If we can't handle that panic gracefully then I'll 👍
pkg/plugins/policies/meshtrafficpermission/api/v1alpha1/meshtrafficpermission_helpers.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
…kuma into feat/rule-based-view
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
…kuma into feat/rule-based-view
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the helper not generated for meshaccesslog?
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Method
MatchedPolicies
is called for each plugin policy for each DPP. It returns the following result:DataplanePolicies
are set in the previous PR #4977. Current PR setsFromRules
andToRules
. The algorithm is explained here.Signed-off-by: Ilya Lobkov ilya.lobkov@konghq.com
Checklist prior to review
TypedMatchedPolicies
and therefore inspect #4978syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? -- No> Changelog:
entry here? No