Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MeshAccessLog): add OmitEmptyValues to MeshAccessLog format #5302

Merged
merged 2 commits into from
Nov 15, 2022
Merged

feat(MeshAccessLog): add OmitEmptyValues to MeshAccessLog format #5302

merged 2 commits into from
Nov 15, 2022

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 14, 2022 •
edited
Loading

Fixes #5290

Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont michaelbeaumont changed the title chore(logs): add OmitEmptyValues to MeshAccessLog format chore(MeshAccessLog): add OmitEmptyValues to MeshAccessLog format Nov 14, 2022
@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Nov 14, 2022 •
edited
Loading

Hi @michaelbeaumont ,
Are there any test files to check the output of the logs ?
Is there a default config, to say explicitly that the values are omitted by default or not ?

@mmorel-35 mmorel-35 marked this pull request as ready for review November 14, 2022 11:59
@mmorel-35 mmorel-35 requested a review from a team as a code owner November 14, 2022 11:59
@mmorel-35 mmorel-35 changed the title chore(MeshAccessLog): add OmitEmptyValues to MeshAccessLog format feat(MeshAccessLog): add OmitEmptyValues to MeshAccessLog format Nov 15, 2022
@mmorel-35
chore(logs): add OmitEmptyValues to MeshAccessLog format
3f1b3cb 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
update golden files
93ec401 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz merged commit 9088ed8 into kumahq:master Nov 15, 2022
@mmorel-35 mmorel-35 deleted the issue-5290 branch November 15, 2022 16:08
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add OmitEmptyValues to MeshAccessLog format
3 participants
@mmorel-35 @michaelbeaumont @jakubdyszkiewicz