Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp): append policy slices #5515

Merged
merged 2 commits into from
Dec 19, 2022
Merged

feat(kuma-cp): append policy slices #5515

merged 2 commits into from
Dec 19, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Dec 15, 2022 •
edited by lahabana
Loading

Fix #5508

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests -- no
  • Manual Universal Tests -- no
  • Manual Kubernetes Tests -- no
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(policy): append policy slices

@jakubdyszkiewicz
feat(kuma-cp): append policy slices
4441c53 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review December 15, 2022 13:26
@jakubdyszkiewicz jakubdyszkiewicz requested review from a team, Automaat and lukidzi and removed request for a team December 15, 2022 13:26
lukidzi
lukidzi reviewed Dec 15, 2022
View reviewed changes
pkg/core/xds/merge.go Outdated Show resolved Hide resolved
lobkovilya
lobkovilya approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@lobkovilya lobkovilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/core/xds/rules.go Outdated Show resolved Hide resolved
pkg/core/xds/merge.go Outdated Show resolved Hide resolved
pkg/core/xds/merge.go Outdated Show resolved Hide resolved
pkg/core/xds/merge.go Outdated Show resolved Hide resolved
@jakubdyszkiewicz
chore: review
6ab4a29 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz enabled auto-merge (squash) December 16, 2022 12:27
@jakubdyszkiewicz jakubdyszkiewicz merged commit f5c0c5b into kumahq:master Dec 19, 2022
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@lobkovilya lobkovilya lobkovilya approved these changes

@Automaat Automaat Automaat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement madr 16 policy field merging
4 participants
@jakubdyszkiewicz @Automaat @lobkovilya @lukidzi