Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(meshhealthcheck): add x-kuma-tags to requests #5722

Merged
merged 1 commit into from
Jan 17, 2023
Merged

feat(meshhealthcheck): add x-kuma-tags to requests #5722

merged 1 commit into from
Jan 17, 2023

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Jan 16, 2023 •
edited
Loading

We add x-kuma-tags to all requests that way things like faultInjection can also apply to health checks

Fix #5718

Signed-off-by: Charly Molter charly.molter@konghq.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(policy): implement MeshHealthCheck policy

@lahabana
feat(meshhealthcheck): add x-kuma-tags to requests
f6abb38 
We add x-kuma-tags to all requests that way things like faultInjection
can also apply to health checks

Fix kumahq#5718

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana requested review from a team, Automaat, bartsmykla and slonka and removed request for a team and bartsmykla January 16, 2023 17:54
@lahabana lahabana merged commit 9648bc6 into kumahq:master Jan 17, 2023
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
@lahabana lahabana deleted the fix5718 branch May 2, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@Automaat Automaat Awaiting requested review from Automaat

@slonka slonka Awaiting requested review from slonka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add x-kuma-tags header to MeshHealthcheck requests
2 participants
@lahabana @jakubdyszkiewicz