Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(policy): create MADR for LB policy #6117

Merged
merged 2 commits into from
Feb 27, 2023

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Feb 23, 2023

Rendered

Changelog: feat(policies): implement MeshLoadBalancingStrategy

Checklist prior to review

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Feb 23, 2023
@lobkovilya lobkovilya requested review from a team, slonka and bartsmykla and removed request for a team February 23, 2023 11:11
@lobkovilya lobkovilya changed the title docs(madr): create MADR for LB policy docs(policies): create MADR for LB policy Feb 23, 2023
@lobkovilya lobkovilya changed the title docs(policies): create MADR for LB policy feat(policy): create MADR for LB policy Feb 23, 2023
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As far as the implementation goes, would we need to/should we handle these MeshLoadBalancing resource inside the MeshHTTPRoute plugin?

docs/madr/decisions/021-lb-policy.md Outdated Show resolved Hide resolved
Co-authored-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Ilya Lobkov <lobkovilya@yandex.ru>
@lobkovilya
Copy link
Contributor Author

As far as the implementation goes, would we need to/should we handle these MeshLoadBalancing resource inside the MeshHTTPRoute plugin?

I think no, we don't have to depend on MeshLoadBalancing inside MeshHTTPRoute plugin. MeshLoadBalancing plugin should run after the MeshHTTPRoute plugin, it needs to find already created Clusters and Routes in ResourceSet.

@lobkovilya lobkovilya merged commit 3359ad7 into kumahq:master Feb 27, 2023
@lahabana
Copy link
Contributor

Approved :)

@lobkovilya lobkovilya deleted the madr/lb-policy branch February 27, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MeshHTTPRoute loadBalancing and localityAware configuration
4 participants