Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): change validation of resources synced to global #6178

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

jakubdyszkiewicz
Copy link
Contributor

Checklist prior to review

"default" should not be taken account into the limit.
On Universal Global CP does not add "default".
On Kubernetes "default" is a namespace.

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested review from a team, bartsmykla and lobkovilya and removed request for a team March 1, 2023 12:17
@jakubdyszkiewicz jakubdyszkiewicz merged commit d15e57e into kumahq:master Mar 1, 2023
@jakubdyszkiewicz jakubdyszkiewicz deleted the fix/name-length branch March 1, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants