feat(helm): make egress resources configurable #6286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow egress resources to be configurable via the Helm values file Fix 6252 Signed-off-by: Joe Dascole <joe.dascole@konghq.com>
fix(kuma-cp): don't let CA requests for other meshes block generation…
dascole
requested review from
a team,
michaelbeaumont and
Automaat
and removed request for
a team
|
/format /golden_files |
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
michaelbeaumont
approved these changes
Mar 16, 2023
There was a problem hiding this comment.
LGTM, we can address the values themselves in a different PR/as part of #6049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow egress resources to be configurable via the Helm values file
Signed-off-by: Joe Dascole joe.dascole@konghq.com
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?