Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatewayapi): always set an explicit HTTPRoute Parents in status #6367

Merged

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Mar 28, 2023

It doesn't have omitempty so this leads to update errors

Changelog: fix(GatewayAPI): always set an explicit HTTPRoute Parents in status

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested review from a team, slonka and lobkovilya and removed request for a team March 28, 2023 12:00
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) March 28, 2023 12:31
@michaelbeaumont michaelbeaumont merged commit ff7b562 into kumahq:master Mar 29, 2023
@michaelbeaumont michaelbeaumont deleted the fix/gatewayapi_route_parents branch March 29, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants