Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GatewayAPI): reconcile Gateways on Secret changes #6754

Merged
merged 1 commit into from
May 15, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented May 12, 2023

Important for example if a Secret appears or disappears and it's used in an HTTPS listener.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont michaelbeaumont requested review from a team, jakubdyszkiewicz and lukidzi and removed request for a team May 12, 2023 12:39
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@johnharris85
Copy link
Contributor

LGTM

@michaelbeaumont michaelbeaumont merged commit 376af7a into kumahq:master May 15, 2023
@michaelbeaumont michaelbeaumont deleted the fix/gapi_gw_on_sec branch May 15, 2023 08:37
bartsmykla pushed a commit that referenced this pull request Feb 25, 2024
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants