fix(kuma-dp): pass sockets in metadata from dp to cp #7218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently socket paths where generated from both the cp and dp. These relied on `os.TempDir()` which may return different results as they run on 2 different machines. With this change we make the paths configurable from the kuma-dp process. The information is then sent in the metadata and can be used during config generation. From a backward compatibility POV there are 2 things to take care of: - We may update the CP and have an old DP still running (the metadata won't have the entries for sockets). - We may have an old DP bootstrap on a newer CP (this bootstrap request won't have the DP set). Fix kumahq#5228 Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana
requested review from
jakubdyszkiewicz and
lobkovilya
and removed request for
a team
lahabana
commented
Jul 10, 2023
Signed-off-by: Charly Molter <charly@molter.io>
lobkovilya
approved these changes
Jul 17, 2023
jakubdyszkiewicz
approved these changes
Jul 17, 2023
Signed-off-by: Charly Molter <charly.molter@konghq.com>
|
100% opened an issue to do this in the future |
Icarus9913
added a commit
to Icarus9913/kuma
that referenced
this pull request
Jun 1, 2024
…ility Refer to kumahq#7218, we kept something to meet the backward compability with the access log socket and metrics socket in the past. Now we need to remove them. Signed-off-by: Icarus Wu <icaruswu66@qq.com>
5 tasks
Icarus9913
added a commit
to Icarus9913/kuma
that referenced
this pull request
Jun 2, 2024
…ility Refer to kumahq#7218, we kept something to meet the backward compability with the access log socket and metrics socket in the past. Now we need to remove them. Signed-off-by: Icarus Wu <icaruswu66@qq.com>
Icarus9913
added a commit
to Icarus9913/kuma
that referenced
this pull request
Jun 4, 2024
…ility Refer to kumahq#7218, we kept something to meet the backward compability with the access log socket and metrics socket in the past. Now we need to remove them. Signed-off-by: Icarus Wu <icaruswu66@qq.com>
Icarus9913
added a commit
to Icarus9913/kuma
that referenced
this pull request
Jun 4, 2024
…ility Refer to kumahq#7218, we kept something to meet the backward compability with the access log socket and metrics socket in the past. Now we need to remove them. Signed-off-by: Icarus Wu <icaruswu66@qq.com>
Icarus9913
added a commit
to Icarus9913/kuma
that referenced
this pull request
Jun 5, 2024
…ility Refer to kumahq#7218, we kept something to meet the backward compability with the access log socket and metrics socket in the past. Now we need to remove them. Signed-off-by: Icarus Wu <icaruswu66@qq.com>
Icarus9913
added a commit
to Icarus9913/kuma
that referenced
this pull request
Jun 6, 2024
…ility Refer to kumahq#7218, we kept something to meet the backward compability with the access log socket and metrics socket in the past. Now we need to remove them. Signed-off-by: Icarus Wu <icaruswu66@qq.com>
Icarus9913
added a commit
to Icarus9913/kuma
that referenced
this pull request
Jun 10, 2024
…ility Refer to kumahq#7218, we kept something to meet the backward compability with the access log socket and metrics socket in the past. Now we need to remove them. Signed-off-by: Icarus Wu <icaruswu66@qq.com>
Icarus9913
added a commit
to Icarus9913/kuma
that referenced
this pull request
Jun 10, 2024
…ility Refer to kumahq#7218, we kept something to meet the backward compability with the access log socket and metrics socket in the past. Now we need to remove them. Signed-off-by: Icarus Wu <icaruswu66@qq.com>
Icarus9913
added a commit
to Icarus9913/kuma
that referenced
this pull request
Jun 10, 2024
…ility Refer to kumahq#7218, we kept something to meet the backward compability with the access log socket and metrics socket in the past. Now we need to remove them. Signed-off-by: Icarus Wu <icaruswu66@qq.com>
Icarus9913
added a commit
to Icarus9913/kuma
that referenced
this pull request
Jun 10, 2024
…ility Refer to kumahq#7218, we kept something to meet the backward compability with the access log socket and metrics socket in the past. Now we need to remove them. Signed-off-by: Icarus Wu <icaruswu66@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently socket paths where generated from both the cp and dp. These relied on
os.TempDir()which may return different results as they run on 2 different machines.With this change we make the paths configurable from the kuma-dp process.
The information is then sent in the metadata and can be used during config generation.
From a backward compatibility POV there are 2 things to take care of:
Fix #5228
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?