Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp): pass context via snapshot reconciler to generateCerts #7231

Merged
merged 3 commits into from
Jul 13, 2023
Merged

fix(kuma-cp): pass context via snapshot reconciler to generateCerts #7231

merged 3 commits into from
Jul 13, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jul 13, 2023 •
edited
Loading

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont michaelbeaumont mentioned this pull request Jul 13, 2023
Merged
7 tasks
@michaelbeaumont michaelbeaumont added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Jul 13, 2023
@michaelbeaumont michaelbeaumont marked this pull request as ready for review July 13, 2023 15:18
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner July 13, 2023 15:18
@michaelbeaumont michaelbeaumont requested review from lobkovilya and lukidzi and removed request for a team July 13, 2023 15:18
@michaelbeaumont
fix(kuma-cp): pass context via snapshot reconciler to generateCerts
9f0d8e7 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
fix: contextcheck errors
3c88474 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
test: update for context in Generate signature
3e2a190 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) July 13, 2023 22:38
@michaelbeaumont michaelbeaumont merged commit df9c5f9 into kumahq:master Jul 13, 2023
@michaelbeaumont michaelbeaumont deleted the fix/pass-ctx-sync branch July 13, 2023 23:00
@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023 •
edited
Loading

backporting to release-2.3 with action

backporting to release-2.1 with action
backporting to release-1.8 with action
backporting to release-2.2 with action

@kumahq kumahq bot mentioned this pull request Jul 13, 2023
Merged
kumahq bot pushed a commit that referenced this pull request Jul 13, 2023
@michaelbeaumont @kumahq
fix(kuma-cp): pass context via snapshot reconciler to generateCerts (#…
b2e0dc5 
…7231)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
This was referenced Jul 13, 2023
Merged
Closed
kumahq bot pushed a commit that referenced this pull request Jul 13, 2023
@michaelbeaumont @kumahq
fix(kuma-cp): pass context via snapshot reconciler to generateCerts (#…
d6fe6ce 
…7231)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
kumahq bot pushed a commit that referenced this pull request Jul 13, 2023
@michaelbeaumont @kumahq
fix(kuma-cp): pass context via snapshot reconciler to generateCerts (#…
8689808 
…7231)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
kumahq bot pushed a commit that referenced this pull request Jul 13, 2023
@michaelbeaumont @kumahq
fix(kuma-cp): pass context via snapshot reconciler to generateCerts (#…
6bd0bd4 
…7231)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
This was referenced Jul 13, 2023
Closed
Merged
kumahq bot pushed a commit that referenced this pull request Jul 13, 2023
@michaelbeaumont @kumahq
fix(kuma-cp): pass context via snapshot reconciler to generateCerts (#…
e35e5a3 
…7231)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request Jul 14, 2023
@michaelbeaumont
fix(kuma-cp): pass context via snapshot reconciler to generateCerts (#…
8d63d2a 
…7231)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request Jul 14, 2023
@kumahq @michaelbeaumont
fix(kuma-cp): pass context via snapshot reconciler to generateCerts (…
55132e0 
…backport of #7231) (#7251)

fix(kuma-cp): pass context via snapshot reconciler to generateCerts (#7231)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request Jul 17, 2023
@michaelbeaumont
fix(kuma-cp): pass context via snapshot reconciler to generateCerts (#…
7031343 
…7231)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request Jul 17, 2023
@michaelbeaumont
fix(kuma-cp): pass context via snapshot reconciler to generateCerts (#…
b0722b2 
…7231)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request Jul 17, 2023
@kumahq @michaelbeaumont
fix(kuma-cp): pass context via snapshot reconciler to generateCerts (…
b45db21 
…backport of #7231) (#7254)

fix(kuma-cp): pass context via snapshot reconciler to generateCerts (#7231)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request Jul 17, 2023
@michaelbeaumont
fix(kuma-cp): pass context via snapshot reconciler to generateCerts (#…
679b687 
…7231)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request Jul 17, 2023
@kumahq @michaelbeaumont
fix(kuma-cp): pass context via snapshot reconciler to generateCerts (…
3552bec 
…backport of #7231) (#7250)

fix(kuma-cp): pass context via snapshot reconciler to generateCerts (#7231)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobkovilya lobkovilya lobkovilya approved these changes

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @lobkovilya