-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MeshGateway): ensure that duplicate listeners are not added when crossMesh is enabled on a listener and Routes specify hostnames #8156
Merged
michaelbeaumont
merged 1 commit into
kumahq:master
from
ttreptow:fix/remove-extra-cross-mesh-chains
Nov 1, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttreptow
requested review from
jakubdyszkiewicz and
lukidzi
and removed request for
a team
October 26, 2023 12:49
ttreptow
force-pushed
the
fix/remove-extra-cross-mesh-chains
branch
from
October 26, 2023 12:52
3898e77
to
9f58886
Compare
I accidentally re-incorporated @michaelbeaumont 's changes while rebasing 🙈 . I'm going to push a fixed commit in a minute |
ttreptow
force-pushed
the
fix/remove-extra-cross-mesh-chains
branch
3 times, most recently
from
October 26, 2023 13:09
f09a3e7
to
e03462e
Compare
lahabana
requested review from
michaelbeaumont
and removed request for
jakubdyszkiewicz
October 26, 2023 13:23
michaelbeaumont
changed the title
Ensure that duplicate listeners are not added when crossMesh is enabled on a listener and Routes specify hostnames
fix: ensure that duplicate listeners are not added when crossMesh is enabled on a listener and Routes specify hostnames
Oct 26, 2023
ttreptow
changed the title
fix: ensure that duplicate listeners are not added when crossMesh is enabled on a listener and Routes specify hostnames
fix(MeshGateway): ensure that duplicate listeners are not added when crossMesh is enabled on a listener and Routes specify hostnames
Oct 26, 2023
michaelbeaumont
requested changes
Oct 31, 2023
@ttreptow unfortunately you need to rebase and add the |
…ed on a listener and Routes specify hostnames In the cross-mesh case, the SNI string will be a kuma SNI string for the gateway service (e.g. edge-gateway{mesh=default,port=tcp-8080}). Thus it is not possible to distinguish hosts at the listener level and no filter chain sni matchers are added. This can lead to a duplicate listener filter chain being added if there are multiple hostnames to route. Thus we truncate the gatewayHosts array to size 1 before creating the listener blocks. Signed-off-by: Tim Treptow <ttreptow@domaintools.com>
ttreptow
force-pushed
the
fix/remove-extra-cross-mesh-chains
branch
from
October 31, 2023 21:49
dc1f331
to
6dd05f1
Compare
michaelbeaumont
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ttreptow !
michaelbeaumont
added
the
ci/run-full-matrix
PR: Runs all possible e2e test combination (expensive use carefully)
label
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the cross-mesh case, the SNI string will be a kuma SNI string for the gateway service (e.g. edge-gateway{mesh=default,port=tcp-8080}). Thus it is not possible to distinguish hosts at the listener level and no filter chain sni matchers are added. This can lead to a duplicate listener filter chain being added if there are multiple hostnames to route.
Thus we truncate the gatewayHosts array to size 1 before creating the listener blocks.
Fixes #8076
Supersedes #8105
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --