Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): require kuma.io/origin: zone label when creating zone-origination policies #8873

Merged

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Jan 16, 2024

Checklist prior to review

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya marked this pull request as ready for review January 18, 2024 13:53
@lobkovilya lobkovilya requested a review from a team as a code owner January 18, 2024 13:53
@lobkovilya lobkovilya requested review from jijiechen, slonka and jakubdyszkiewicz and removed request for a team January 18, 2024 13:53
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is optional UX feature. I remember we talked about disabling it via env var if someone don't want to have this validation. Should we introduce such env var?

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya force-pushed the feat/require-origin-label-on-zone-cp branch from 88a7864 to 80574c0 Compare January 22, 2024 11:46
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya merged commit 17025b3 into kumahq:master Jan 23, 2024
11 of 12 checks passed
@lobkovilya lobkovilya deleted the feat/require-origin-label-on-zone-cp branch January 23, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It's possible to remove global-originated policy on zone
2 participants