Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MeshGateway): fix MeshTCPRoute on MeshGateway #9167

Merged
merged 1 commit into from
Feb 8, 2024
Merged

fix(MeshGateway): fix MeshTCPRoute on MeshGateway #9167

merged 1 commit into from
Feb 8, 2024

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Feb 7, 2024

  • MeshTCPRoute when applied to a MeshGateway would panic thus making it unusable. This fixes this and backfills e2e tests
  • Refactor tests to make them easier to maintain

Fix #9154

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@lahabana lahabana requested a review from a team as a code owner February 7, 2024 17:22
@lahabana lahabana requested review from jijiechen, slonka and lukidzi and removed request for a team February 7, 2024 17:22
slonka
slonka approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good 👍. I think we should spend some time thinking about how to avoid such errors in the future. Can we have some static analysis tools that would catch it? Should we reenable code coverage? Or should we just be more vigilant on reviews and always require an E2E test?

pkg/plugins/policies/meshhttproute/plugin/v1alpha1/gateway_routes.go Show resolved Hide resolved
pkg/plugins/policies/meshtcproute/plugin/v1alpha1/plugin_test.go Show resolved Hide resolved
@lahabana
fix(MeshGateway): fix MeshTCPRoute on MeshGateway
1b85d9d 
- MeshTCPRoute when applied to a MeshGateway would panic
thus making it unusable. This fixes this and backfills e2e tests
- Refactor tests to make them easier to maintain

Fix kumahq#9154

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana merged commit 67ee1be into kumahq:master Feb 8, 2024
11 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024 •
edited
Loading

backporting to release-2.3 with action

backporting to release-2.2 with action
backporting to release-2.4 with action
backporting to release-2.5 with action
backporting to release-2.6 with action

kumahq bot pushed a commit that referenced this pull request Feb 8, 2024
@lahabana @kumahq
fix(MeshGateway): fix MeshTCPRoute on MeshGateway (#9167)
85e0984 
- MeshTCPRoute when applied to a MeshGateway would panic
thus making it unusable. This fixes this and backfills e2e tests
- Refactor tests to make them easier to maintain

Fix #9154

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@kumahq kumahq bot mentioned this pull request Feb 8, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Feb 8, 2024
@lahabana @kumahq
fix(MeshGateway): fix MeshTCPRoute on MeshGateway (#9167)
5265b2e 
- MeshTCPRoute when applied to a MeshGateway would panic
thus making it unusable. This fixes this and backfills e2e tests
- Refactor tests to make them easier to maintain

Fix #9154

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@kumahq kumahq bot mentioned this pull request Feb 8, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Feb 8, 2024
@lahabana @kumahq
fix(MeshGateway): fix MeshTCPRoute on MeshGateway (#9167)
9ed9f8f 
- MeshTCPRoute when applied to a MeshGateway would panic
thus making it unusable. This fixes this and backfills e2e tests
- Refactor tests to make them easier to maintain

Fix #9154

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@kumahq kumahq bot mentioned this pull request Feb 8, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Feb 8, 2024
@lahabana @kumahq
fix(MeshGateway): fix MeshTCPRoute on MeshGateway (#9167)
c1b5dfc 
- MeshTCPRoute when applied to a MeshGateway would panic
thus making it unusable. This fixes this and backfills e2e tests
- Refactor tests to make them easier to maintain

Fix #9154

Signed-off-by: Charly Molter <charly.molter@konghq.com>
kumahq bot pushed a commit that referenced this pull request Feb 8, 2024
@lahabana @kumahq
fix(MeshGateway): fix MeshTCPRoute on MeshGateway (#9167)
a7362f2 
- MeshTCPRoute when applied to a MeshGateway would panic
thus making it unusable. This fixes this and backfills e2e tests
- Refactor tests to make them easier to maintain

Fix #9154

Signed-off-by: Charly Molter <charly.molter@konghq.com>
This was referenced Feb 8, 2024
Closed
Merged
lahabana pushed a commit that referenced this pull request Feb 9, 2024
@kumahq
fix(MeshGateway): fix MeshTCPRoute on MeshGateway (backport of #9167) (…
744862b 
…#9180)

* fix(MeshGateway): fix MeshTCPRoute on MeshGateway (#9167)

- MeshTCPRoute when applied to a MeshGateway would panic
thus making it unusable. This fixes this and backfills e2e tests
- Refactor tests to make them easier to maintain

Fix #9154

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@johncowen johncowen mentioned this pull request Feb 13, 2024
Merged
@lahabana lahabana deleted the fix9154 branch March 29, 2024 12:43
@BrewTestBot BrewTestBot mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont left review comments

@slonka slonka slonka approved these changes

@jijiechen jijiechen Awaiting requested review from jijiechen jijiechen is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MeshGateway error with MeshTCPRoute
3 participants
@lahabana @michaelbeaumont @slonka