Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GatewayAPI): don't add HTTPRoute status if Kuma isn't the controller #9228

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix(GatewayAPI): don't add HTTPRoute status if Kuma isn't the controller #9228

merged 1 commit into from
Feb 13, 2024

Conversation

michaelbeaumont
Copy link
Contributor

We were accidentally setting a status for Kuma.

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont
fix(gatewayapi): don't add conditions for every parentRef
47b79bd 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont linked an issue Feb 13, 2024 that may be closed by this pull request
Reconcilliation loop between GAPI of Kuma and KIC #9158
Closed
@michaelbeaumont michaelbeaumont marked this pull request as ready for review February 13, 2024 11:38
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner February 13, 2024 11:38
@michaelbeaumont michaelbeaumont requested review from jakubdyszkiewicz, Automaat and lukidzi and removed request for a team February 13, 2024 11:38
@michaelbeaumont michaelbeaumont merged commit 4d1b280 into kumahq:master Feb 13, 2024
16 checks passed
@michaelbeaumont michaelbeaumont deleted the fix/gapi-statuses branch February 13, 2024 13:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2024 •
edited
Loading

backporting to release-2.5 with action

backporting to release-2.2 with action
backporting to release-2.4 with action
backporting to release-2.6 with action
backporting to release-2.3 with action

kumahq bot pushed a commit that referenced this pull request Feb 13, 2024
@michaelbeaumont @kumahq
fix(gatewayapi): don't add HTTPRoute status if Kuma isn't the control…
121601f 
…ler (#9228)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
kumahq bot pushed a commit that referenced this pull request Feb 13, 2024
@michaelbeaumont @kumahq
fix(gatewayapi): don't add HTTPRoute status if Kuma isn't the control…
40ff3dc 
…ler (#9228)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
This was referenced Feb 13, 2024
Closed
Merged
kumahq bot pushed a commit that referenced this pull request Feb 13, 2024
@michaelbeaumont @kumahq
fix(gatewayapi): don't add HTTPRoute status if Kuma isn't the control…
a14c4d1 
…ler (#9228)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@kumahq kumahq bot mentioned this pull request Feb 13, 2024
Merged
kumahq bot pushed a commit that referenced this pull request Feb 13, 2024
@michaelbeaumont @kumahq
fix(gatewayapi): don't add HTTPRoute status if Kuma isn't the control…
5d2c810 
…ler (#9228)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@kumahq kumahq bot mentioned this pull request Feb 13, 2024
Closed
kumahq bot pushed a commit that referenced this pull request Feb 13, 2024
@michaelbeaumont @kumahq
fix(gatewayapi): don't add HTTPRoute status if Kuma isn't the control…
ad10286 
…ler (#9228)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@kumahq kumahq bot mentioned this pull request Feb 13, 2024
Closed
michaelbeaumont added a commit that referenced this pull request Feb 13, 2024
@kumahq @michaelbeaumont
fix(gatewayapi): don't add HTTPRoute status if Kuma isn't the control…
a3cc90a 
…ler (backport of #9228) (#9236)

fix(gatewayapi): don't add HTTPRoute status if Kuma isn't the controller (#9228)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
michaelbeaumont added a commit that referenced this pull request Feb 13, 2024
@kumahq @michaelbeaumont
fix(gatewayapi): don't add HTTPRoute status if Kuma isn't the control…
56bd4bc 
…ler (backport of #9228) (#9235)

fix(gatewayapi): don't add HTTPRoute status if Kuma isn't the controller (#9228)

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
@lahabana lahabana changed the title fix(gatewayapi): don't add HTTPRoute status if Kuma isn't the controller fix(GatewayApi): don't add HTTPRoute status if Kuma isn't the controller Apr 11, 2024
@lahabana lahabana changed the title fix(GatewayApi): don't add HTTPRoute status if Kuma isn't the controller fix(GatewayAPI): don't add HTTPRoute status if Kuma isn't the controller Apr 15, 2024
@BrewTestBot BrewTestBot mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@Automaat Automaat Awaiting requested review from Automaat Automaat is a code owner automatically assigned from kumahq/kuma-maintainers

@lukidzi lukidzi Awaiting requested review from lukidzi lukidzi is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reconcilliation loop between GAPI of Kuma and KIC
2 participants
@michaelbeaumont @jakubdyszkiewicz