Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MeshTCPRoute): allow MeshGateway listener tags #9239

Merged
merged 2 commits into from
Feb 13, 2024
Merged

fix(MeshTCPRoute): allow MeshGateway listener tags #9239

merged 2 commits into from
Feb 13, 2024

Conversation

michaelbeaumont
Copy link
Contributor

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@michaelbeaumont
test(MeshTCPRoute): add validation
87f38e6 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
fix(MeshTCPRoute): allow MeshGateway listener tags
ec86225 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner February 13, 2024 15:05
@michaelbeaumont michaelbeaumont requested review from slonka, jakubdyszkiewicz and lukidzi and removed request for a team February 13, 2024 15:05
@michaelbeaumont michaelbeaumont merged commit 2160302 into kumahq:release-2.6 Feb 13, 2024
12 checks passed
@michaelbeaumont michaelbeaumont deleted the fix/meshtcproute-gw-tags branch February 13, 2024 15:33
michaelbeaumont added a commit to michaelbeaumont/kuma that referenced this pull request Feb 13, 2024
@michaelbeaumont
fix(MeshTCPRoute): allow MeshGateway listener tags (kumahq#9239)
a03e368 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont mentioned this pull request Feb 13, 2024
Merged
5 tasks
michaelbeaumont added a commit to michaelbeaumont/kuma that referenced this pull request Feb 13, 2024
@michaelbeaumont
fix(MeshTCPRoute): allow MeshGateway listener tags (kumahq#9239)
295fd0e 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@BrewTestBot BrewTestBot mentioned this pull request Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz jakubdyszkiewicz is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @lukidzi