Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update require php value #4

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Update require php value #4

merged 4 commits into from
Nov 28, 2023

Conversation

waviaei
Copy link
Member

@waviaei waviaei commented Nov 27, 2023

For #3

@waviaei waviaei self-assigned this Nov 27, 2023
@waviaei
Copy link
Member Author

waviaei commented Nov 27, 2023

composer require kunoichi/set-menu:"dev-waviaei-patch-1"
ブランチを指定して、このPRでPHP8.xでも require できることを確認

@waviaei
Copy link
Member Author

waviaei commented Nov 28, 2023

#8
set_menu_default_menu_lifetime
set_menu_default_sidebar_lifetime
のフィルターを追加。

fumikito
fumikito approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@fumikito fumikito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fumikito fumikito merged commit bedddb8 into master Nov 28, 2023
@fumikito fumikito deleted the waviaei-patch-1 branch November 28, 2023 16:16
@waviaei waviaei mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fumikito fumikito fumikito approved these changes

Assignees

@waviaei waviaei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waviaei @fumikito