Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes after a few hours #28

Closed
hotice opened this issue Feb 8, 2017 · 7 comments
Closed

Crashes after a few hours #28

hotice opened this issue Feb 8, 2017 · 7 comments

Comments

@hotice
Copy link

hotice commented Feb 8, 2017

Kupfer v303 crashes after a few hours of usage in Ubuntu 16.10. Edit: From what I can tell, this looks like it's caused by the clipboard plugin, when using the Shutter application (screenshot tool), which copies newly created screenshots to the clipboard (as images).

Here's the log:

D [kupfer.plugin.clipboard] ClipboardSource: Loaded items
D [kupfer.plugin.documents] RecentsSource: Loaded items
D [kupfer.desktop_launch]: Launched [b'terminix'] kupfer.py-9685-andrei-desktop-terminix-1_TIME20767995 pid: 10983
GLib-CRITICAL **: Source ID 3555 was not found when attempting to remove it at /usr/share/perl5/Shutter/App/ShutterNotification.pm line 186.
GLib-CRITICAL **: Source ID 4544 was not found when attempting to remove it at /usr/bin/shutter line 7249.
Argument "rectangle" isn't numeric in numeric eq (==) at /usr/share/perl5/Shutter/Draw/DrawingTool.pm line 2366.
GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed at /usr/share/perl5/Shutter/Draw/DrawingTool.pm line 1342.
GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed at /usr/share/perl5/Shutter/Draw/DrawingTool.pm line 1342.
GLib-CRITICAL **: Source ID 6424 was not found when attempting to remove it at /usr/bin/shutter line 7249.
Traceback (most recent call last):
  File "/usr/share/kupfer/kupfer/weaklib.py", line 27, in __call__
    attr(*args, **kwargs)
  File "/usr/share/kupfer/kupfer/plugin/clipboard.py", line 132, in _clipboard_changed
    is_selection = (event.selection == Gdk.SELECTION_PRIMARY)
RecursionError: maximum recursion depth exceeded while calling a Python object
Fatal Python error: Cannot recover from stack overflow.

Current thread 0x00007f7a66990700 (most recent call first):
  File "/usr/share/kupfer/kupfer/plugin/clipboard.py", line 132 in _clipboard_changed
  ...
Aborted
@bluss
Copy link
Member

bluss commented Feb 8, 2017

Thanks for the bug report. It makes sense it can get into trouble when setting and getting the clipboard in the same function.

What do you think about the copy selection to clipboard feature? Is it important? I'd propose replacing it with simply "[ ] Include selection in clipboard history".

(I've consolidated github accounts)

@bluss
Copy link
Member

bluss commented Feb 8, 2017

Wait, do you have another clipboard handler active at the same time? Something that also syncs the clipboards?

bluss added a commit that referenced this issue Feb 8, 2017
Try to fix a bug that looked like an unbounded recursion for some
reason.

Issue #28
@bluss
Copy link
Member

bluss commented Feb 8, 2017

I'd try the new version and hopefully this is gone.

@hotice
Copy link
Author

hotice commented Feb 9, 2017

Wait, do you have another clipboard handler active at the same time? Something that also syncs the clipboards?

I have KDE Connect, which syncs the system clipboard to my Android phone clipboard. That's all I think.

I'll try the new version, thanks!

@hotice
Copy link
Author

hotice commented Feb 9, 2017

Regarding this:

What do you think about the copy selection to clipboard feature? Is it important? I'd propose replacing it with simply "[ ] Include selection in clipboard history".

Do you mean the "Copy selected text to primary clipboard" option from the Clipboards plugin? I didn't have that enabled. And I just enabled it, selected some text and Kupfer crashed on my second attempt to paste. The feature is nice (although confusing), but not that important :D (I'm still using v303 because Launchpad is very slow today).

@hotice
Copy link
Author

hotice commented Feb 10, 2017

Well it no longer crashed while using Kupfer 304.1 about 7 hours so I guess it's fixed.

@hotice hotice closed this as completed Feb 10, 2017
@bluss
Copy link
Member

bluss commented Feb 10, 2017

Thanks for helping to fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants