Refactors all package code to strictNullChecks = true #262

joelalejandro · 2021-02-09T04:07:16Z

Resolves #250.

spersico · 2021-02-09T12:57:35Z

src/serializers/serializer.ts

@@ -213,12 +213,13 @@ export default class JsonApiSerializer implements IJsonApiSerializer {
                            attribute => subResourceClass.schema.attributes[attribute] === Password
                          )
                        ]),
-                        relationships: nestedResources.filter
+                        // A drunk Santiago walks in the bar...
+                        relationships: {} // nestedResources.filter


there's a story there, I'm sure...

If I could just remember 😝...

spersico

Awesome job! There were a couple of cases that I see that you type the same thing twice. I'm guessing that the type checker was being dumb, and yelling at you.

LGTM!

refactored all package to strictNullChecks

3173435

joelalejandro added this to the 1.1.0 milestone Feb 9, 2021

joelalejandro requested a review from spersico February 9, 2021 04:07

joelalejandro self-assigned this Feb 9, 2021

spersico reviewed Feb 9, 2021

View reviewed changes

spersico approved these changes Feb 9, 2021

View reviewed changes

joelalejandro merged commit d2e13e6 into master Feb 9, 2021

joelalejandro deleted the feature/null-safe branch February 9, 2021 13:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactors all package code to strictNullChecks = true #262

Refactors all package code to strictNullChecks = true #262

joelalejandro commented Feb 9, 2021

spersico Feb 9, 2021

spersico left a comment

Refactors all package code to strictNullChecks = true #262

Refactors all package code to strictNullChecks = true #262

Conversation

joelalejandro commented Feb 9, 2021

spersico Feb 9, 2021

Choose a reason for hiding this comment

spersico left a comment

Choose a reason for hiding this comment