Migration from tslint to typescript-eslint #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spersico
approved these changes
Oct 10, 2021
| @@ -51,9 +53,14 @@ | |||
| "@types/pluralize": "^0.0.29", | |||
| "@types/supertest": "^2.0.10", | |||
| "@types/ws": "^7.4.4", | |||
| "@typescript-eslint/eslint-plugin": "^4.33.0", | |||
| "@typescript-eslint/parser": "^4.33.0", | |||
| "eslint": "^7.32.0", | |||
There was a problem hiding this comment.
I installed it without version preferences, probably 8.x is still pre-release.
| @@ -223,7 +241,7 @@ export default class Application { | |||
|
|
|||
| resolve(); | |||
| }); | |||
| }) | |||
| }), | |||
There was a problem hiding this comment.
is this correct? I don't remember this function, but I read https://eslint.org/docs/rules/no-async-promise-executor and this seems like a good catch from the linter isn't it?
There was a problem hiding this comment.
The scope of the PR was simply to migrate from one linter to the next. All of the rules I've disabled are improvement opportunities for the codebase, but I didn't want to get them all here, as the PR would become substantially larger in terms of changeset.
We can tackle this in separate issues, one per rule.
spersico
added
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #280.
eslint, minimum relinting applied.