Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI enclave inspect displays incorrect service status #1351

Closed
tedim52 opened this issue Sep 19, 2023 · 1 comment · Fixed by #1560 or #1556
Closed

CLI enclave inspect displays incorrect service status #1351

tedim52 opened this issue Sep 19, 2023 · 1 comment · Fixed by #1560 or #1556
Assignees
@h4ck3rk3y
Labels
bug Something isn't working painful Painful bug

Comments

@tedim52
Copy link
Contributor

tedim52 commented Sep 19, 2023 •
edited

What's your CLI version?

0.82.24

Description & steps to reproduce

kurtosis enclave inspect delicate-circle

Name:           delicate-circle
UUID:            d4714e488001
Status:          RUNNING
Creation Time:   Thu, 14 Sep 2023 23:02:27 EDT

========================================= Files Artifacts =========================================
UUID           Name
6794261e33a0   config_file

========================================== User Services ==========================================
UUID           Name        Ports    Status
d3e6e5d6d2ef   relayer     <none>   RUNNING
e124c43d46b0   validator   <none>   RUNNING
e124c43d46b0   validator   <none>   RUNNING

Even though docker reports these services have exited.

0b59b4d7e02b   gcr.io/abacus-labs-dev/hyperlane-agent:9612623-20230829-154513   "/bin/sh -c ./relayer"   4 days ago    Exited (1) 4 days ago                                                                relayer--d3e6e5d6d2ef4724abfc82d231b0e137
1314f28abd3d   gcr.io/abacus-labs-dev/hyperlane-agent:9612623-20230829-154513   "/bin/sh -c ./valida…"   4 days ago    Exited (1) 27 hours ago

Desired behavior

enclave inspect should report these services are STOPPED not RUNNING.

What is the severity of this bug?

Painful; this is causing significant friction in my workflow.
@tedim52 tedim52 added the bug Something isn't working label Sep 19, 2023
@github-actions github-actions bot added the painful Painful bug label Sep 19, 2023
@tedim52 tedim52 self-assigned this Sep 19, 2023
@leeederek
Copy link
Contributor

Hey @tedim52 - this bug hurts our UX, thanks for flagging.

@h4ck3rk3y h4ck3rk3y self-assigned this Oct 13, 2023
@h4ck3rk3y h4ck3rk3y mentioned this issue Oct 16, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 16, 2023
@h4ck3rk3y
fix: show container status instead of service status in enclave inspe…
3e1208b 
…ct (#1560)

## Description:
If a service eventually dies we would still show `RUNNING` while in
reality it would be stopped

1. Create an enclave
2. Stop a service
3. Use inspect -> this prints service status Running (Kurtosis was told
to keep it running)

Post this PR

3. This would print container status -> Stopped - actually reflecting
reality


## Is this change user facing?
YES

## References (if applicable):
Closes #1351
@kurtosisbot kurtosisbot mentioned this issue Oct 16, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 16, 2023
@kurtosisbot
chore(main): release 0.84.7 (#1556)
ed66cc3 
🤖 I have created a release *beep* *boop*
---


##
[0.84.7](0.84.6...0.84.7)
(2023-10-16)


### Features

* Add create enclave utils to SDK
([#1550](#1550))
([eb952bb](eb952bb))
* provide granular progress of starlark package run
([#1548](#1548))
([8b20031](8b20031))
* rename kurtosis context "switch" to "set"
([#1537](#1537))
([ccff275](ccff275))


### Bug Fixes

* propagate unexpected test errors via the test framework
([#1559](#1559))
([c463ae2](c463ae2))
* show container status instead of service status in enclave inspect
([#1560](#1560))
([3e1208b](3e1208b)),
closes [#1351](#1351)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@h4ck3rk3y h4ck3rk3y

Labels
bug Something isn't working painful Painful bug
Projects
None yet
Milestone
No milestone
3 participants
@h4ck3rk3y @tedim52 @leeederek