Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show container status instead of service status in enclave inspect #1560

Merged
merged 2 commits into from Oct 16, 2023
Merged

fix: show container status instead of service status in enclave inspect #1560

merged 2 commits into from Oct 16, 2023

Conversation

h4ck3rk3y
Copy link
Contributor

Description:

If a service eventually dies we would still show RUNNING while in reality it would be stopped

  1. Create an enclave
  2. Stop a service
  3. Use inspect -> this prints service status Running (Kurtosis was told to keep it running)

Post this PR

  1. This would print container status -> Stopped - actually reflecting reality

Is this change user facing?

YES

References (if applicable):

Closes #1351

tedim52
tedim52 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@tedim52 tedim52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h4ck3rk3y h4ck3rk3y added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit 3e1208b Oct 16, 2023
32 checks passed
@h4ck3rk3y h4ck3rk3y deleted the gyani/better-status branch October 16, 2023 13:08
@kurtosisbot kurtosisbot mentioned this pull request Oct 16, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 16, 2023
@kurtosisbot
chore(main): release 0.84.7 (#1556)
ed66cc3 
🤖 I have created a release *beep* *boop*
---


##
[0.84.7](0.84.6...0.84.7)
(2023-10-16)


### Features

* Add create enclave utils to SDK
([#1550](#1550))
([eb952bb](eb952bb))
* provide granular progress of starlark package run
([#1548](#1548))
([8b20031](8b20031))
* rename kurtosis context "switch" to "set"
([#1537](#1537))
([ccff275](ccff275))


### Bug Fixes

* propagate unexpected test errors via the test framework
([#1559](#1559))
([c463ae2](c463ae2))
* show container status instead of service status in enclave inspect
([#1560](#1560))
([3e1208b](3e1208b)),
closes [#1351](#1351)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
@tedim52 tedim52 mentioned this pull request Oct 16, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2023
@tedim52
fix: show container status instead of service status in UI (#1567)
4b75980 
## Description:
This change is the sister to this PR
#1560 which makes the same
change in the CLI.

## Is this change user facing?
YES

## References: 
#1560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedim52 tedim52 tedim52 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI enclave inspect displays incorrect service status
2 participants
@h4ck3rk3y @tedim52