Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[efficiency]: table_printer doesnt correctly align for colored input - fix it #213

Open
h4ck3rk3y opened this issue Mar 15, 2023 · 0 comments
Labels
efficiency Behind-the-scenes work (usually infra) that allows us to deliver faster in this repo

Comments

@h4ck3rk3y
Copy link
Contributor

Background and motivation

We have started supporting colored outputs for enclave ls and inspect with bold table headers.

Current behavior

In the following #195 we made the column headers bold and allowed for colors to be passed in

  1. If someone isn't passing colored input in rows, there is no problem
  2. If someone is passing the colored columns at the end, there is no problem
  3. If a colored column is in the middle then alignment breaks a little

Desired behavior

We don't need the hacks that #195 introduces and the table_printer API just works independently of text being colored or not

How important is this feature or improvement to you?

Nice to have, this feature would make using Kurtosis more enjoyable.

@h4ck3rk3y h4ck3rk3y added feature request efficiency Behind-the-scenes work (usually infra) that allows us to deliver faster in this repo and removed feature request labels Mar 15, 2023
@h4ck3rk3y h4ck3rk3y changed the title [FR]: Figure out the table_printer story for aligning colored output [efficiency]: Figure out the table_printer story for aligning colored output Mar 15, 2023
@h4ck3rk3y h4ck3rk3y changed the title [efficiency]: Figure out the table_printer story for aligning colored output [efficiency]: table_printer doesnt correctly align for colored input - fix it Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
efficiency Behind-the-scenes work (usually infra) that allows us to deliver faster in this repo
Projects
None yet
Development

No branches or pull requests

1 participant