-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node.js 14 compatibility #52
Conversation
Resolves warnings (shelljs/shelljs#991): $ node --version v14.1.0 $ npm run test > git-rev-sync@2.0.0 test ~/src/git-rev-sync-js > node tests/index tests passed (node:143612) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'ls' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'find' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'grep' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'head' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'ln' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'mkdir' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'rm' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'mv' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'sed' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'set' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'sort' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'tail' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'test' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'to' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'toEnd' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'touch' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'uniq' of module exports inside circular dependency (node:143612) Warning: Accessing non-existent property 'which' of module exports inside circular dependency
Hi, this MR would be really useful for our projects, this is one of the last dependencies causing us some trouble with our Node 14 update. It seems, that this MR breaks support for older version of Node (0.10 - 0.12), maybe its time to drop their support? It would be great if some of the maintainers took a look at this :) |
Bumping this to also add the official life dates for Node versions, for those who are curious: |
+1 |
Published as |
published as v3.0.0; feel free to take a look and let me know if there are any open issues |
Under Node.js 14 this is affected by shelljs/shelljs#991:
Proposed changes: