<CI>(makefile): add black and isort for formatting #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david30907d
commented
Jan 30, 2022
Comment on lines
+24
to
+25
| - name: Run linters | ||
| run: make lint |
There was a problem hiding this comment.
will check if every contributors has format their PR
david30907d
commented
Jan 30, 2022
Makefile
Outdated
Comment on lines
1
to
8
| format: | ||
| isort --fss -w 88 . | ||
| black . | ||
|
|
||
| lint: | ||
| isort --fss -w 88 --check-only . | ||
| black . --check | ||
| flake8 kuwala/core kuwala/common |
There was a problem hiding this comment.
will sort imports, format codebase and use flake8 to do some simple check
There was a problem hiding this comment.
only check kuwala/core and common because there's lot's of exception in pipelines
want to punt on this in this PR 😛
david30907d
force-pushed
the
add-linter-formater
branch
from
8467362
to
b49180e
Compare
|
passed in my fork |
mattigrthr
reviewed
Jan 31, 2022
david30907d
force-pushed
the
add-linter-formater
branch
from
021fffb
to
36b8b72
Compare
mattigrthr
requested changes
Feb 1, 2022
There was a problem hiding this comment.
When removing the poetry files created during the linting process everything works fine. Please have a look at the comments for more details. After addressing the comments I think it's ready to merge. I've tested the demo and the CLI and everything's still working.
david30907d
force-pushed
the
add-linter-formater
branch
from
21b84f3
to
8e21952
Compare
mattigrthr
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.