-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edits to the Datasets tab #188
Comments
Merged
mewim
added a commit
that referenced
this issue
Aug 19, 2024
* Fix grammar generation * Publish next branch as dev build (#151) * Update Dockerfile to install libatomic1 * Implemented query progress (#152) * Implemented query progress * Run linters * Fix grammar generation * Publish next branch as dev build (#151) * Update Dockerfile to install libatomic1 * Implemented query progress * Run linters * Publish next branch as dev build (#151) * Implemented query progress * Run linters * Implemented feedback --------- Co-authored-by: Lint Bot <MSebanc@users.noreply.github.com> Co-authored-by: Chang Liu <liuc223@gmail.com> * Update kuzu * Fix deduplication issue (#172) * Update kuzu * Data import UI (#174) * X * Update kuzu * Update kuzu * Update grammar * X * X * X * X * X * X * X * X * X * X * X * Add dialog when files are initially selected * X * X * Improve parquet format detection * X * X * X * Minor fix * Fix custom CSV format issues for previewing and type detection (#175) * X * X * X * X * X * X * Additional import ui fixes I (#176) * Refactor ImporterViewFileProcessingModal with ImporterViewProcessingModal * Fix column ignore functionality * Additional validation rules for import ui (#177) * Fix preview header display * X * Address column name change for from and to keys * X * X * X * X * X * Refactor ImporterViewValidationModal component for error display * Refactor planning to use DDL module * Import UI fix (#178) * Handle simple import cases independently * Refactor ImporterViewValidationModal and ImporterViewProcessingModal components * Improve uploading efficiency with multer dependency (#179) * Improve uploading efficiency with multer dependency * X * Lint * X * X * Fix several issues in planning * Lint * Additional fixes (#180) * Fix table name handling with special chars * Delete temporary files in Import.js router * X * Refactor * X * Lint * Import UI fix (#181) * Improve wording * Improve UI consistency * Update kuzu * Update grammar * Update server API routes for read-only mode * Bump kuzu to 0.5.0 * Address #183 (#194) * Fix rel validation (#195) * Enable src and dst key validation for existing rel tables * Add file remove confirmation hack * Address 188 (#196) * Address #188 * Improve error message * Improve style for very long table name (#199) * Make column name case insensitive (#200) * Add in-memory mode support * Update kuzu * Update submodule * Address comments in #201 (#206) * Fix #203 * Fix #202 * Fix #209 (#211) * Handle #210 * Update grammar --------- Co-authored-by: Mattias <81063080+MSebanc@users.noreply.github.com> Co-authored-by: Lint Bot <MSebanc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was playing around with Explorer and realized that now that we have an Import Data tab, we should be more clear in the message we have in Datasets tab. These two tabs are confusing. I think it's easy to think that "Datasets" is a tab that shows your imported CSV/parquet files.
I think the ideal solution would be to merge these inside "Import Data". On the left panel of Import Data, i.e., the "+Add More Files" column, below could be "Bundled Datasets", which have a separate button to load them. This part could be disabled/gray with a warning if you already have created a manual database.
But for now, we could also do a very minor change to modify the warning message when you go to "Datasets" tab: " You have already loaded a database. You can still review the schema of the bundled datasets. If you want to load a different dataset, please restart your Kùzu Explorer Docker image with an empty database or drop all tables in the current database." to something like: "This panel is to create a database from bundled files. You have already created your own database. You can still review the schema of the bundled datasets. If you want to load a bundled dataset, please restart your Kùzu Explorer with an empty database or drop all tables in the current database."
The text was updated successfully, but these errors were encountered: