Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix og url and add overrides #117

Merged
merged 4 commits into from
Apr 7, 2024
Merged

Fix og url and add overrides #117

merged 4 commits into from
Apr 7, 2024

Conversation

prrao87
Copy link
Member

@prrao87 prrao87 commented Apr 3, 2024

  • Fix URL for og image
  • Move the blog url to external link within header
  • Fix broken links

@prrao87 prrao87 requested a review from mewim April 3, 2024 19:56
@prrao87
Copy link
Member Author

prrao87 commented Apr 3, 2024

@mewim I'd like to make the blog URL on the header look like below (from what I've seen in other blogs), so that it's obvious to the user that it's an external link that takes them out of the docs. An example from here is shown below.

image

Would you be able to make the updates to include this icon? The code that overrides the default header is here.

@mewim
Copy link
Member

mewim commented Apr 7, 2024

@mewim I'd like to make the blog URL on the header look like below (from what I've seen in other blogs), so that it's obvious to the user that it's an external link that takes them out of the docs. An example from here is shown below.

Done

@prrao87 prrao87 merged commit 171bb8f into main Apr 7, 2024
2 checks passed
@prrao87 prrao87 deleted the overrides branch April 7, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants