Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue-1643 #1786

Merged
merged 1 commit into from
Jul 9, 2023
Merged

Fix issue-1643 #1786

merged 1 commit into from
Jul 9, 2023

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented Jul 9, 2023 •
edited
Loading

Fix #1643

andyfengHKU
andyfengHKU reviewed Jul 9, 2023
View reviewed changes
test/test_files/exceptions/binder/empty_db_binder_error.test

--

-CASE MissingQueryNode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw should we put this into binder_error.test and then split the file at some point?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To produce the error, i need a fresh database without any nodetables. So i can't put this file into binder_error.test

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0448e00) 91.08% compared to head (a496c11) 91.08%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1786   +/-   ##
=======================================
  Coverage   91.08%   91.08%           
=======================================
  Files         773      773           
  Lines       28312    28314    +2     
=======================================
+ Hits        25789    25791    +2     
  Misses       2523     2523
Impacted Files Coverage Δ
src/binder/bind/bind_graph_pattern.cpp 95.36% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@acquamarin acquamarin merged commit 863c462 into master Jul 9, 2023
@acquamarin acquamarin deleted the issue-1643 branch July 9, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyfengHKU andyfengHKU andyfengHKU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WITH NULL segmentation fault
2 participants
@acquamarin @andyfengHKU