Rework var list finalize #2392
Merged
Rework var list finalize #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2392 +/- ##
==========================================
+ Coverage 91.18% 91.20% +0.01%
==========================================
Files 1012 1012
Lines 35933 35933
==========================================
+ Hits 32767 32771 +4
+ Misses 3166 3162 -4
☔ View full report in Codecov by Sentry. |
ray6080
force-pushed
the
var-list-finalize
branch
from
a3936f2
to
c7ba0b0
Compare
acquamarin
approved these changes
Nov 11, 2023
ray6080
force-pushed
the
var-list-finalize
branch
from
c7ba0b0
to
f04406a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VarListColumnChunk::writeis expected to write a var list value to a given position inside the column chunk, and there is no enforcement of the order of given positions. For example,writecan take[10,20]to pos 5,[1,2,8]to pos 1, etc.However, the layout of var list column requires
offsetsto be sorted based on positions in the column chunk.This PR introduces an extra indices column chunk to handle the ordering difference. During
write, an extra index is recorded intoindicesto track where the var list value is stored. Andfinalizeis called afterwrites are done, which re-append var list values according to their position in the column chunk.