Implement s3 multi-part upload #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acquamarin
force-pushed
the
s3-upload
branch
2 times, most recently
from
ece0777
to
2a352ba
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2697 +/- ##
=======================================
Coverage 93.42% 93.43%
=======================================
Files 1072 1072
Lines 40550 40549 -1
=======================================
+ Hits 37883 37886 +3
+ Misses 2667 2663 -4 ☔ View full report in Codecov by Sentry. |
ray6080
approved these changes
Jan 23, 2024
acquamarin
force-pushed
the
s3-upload
branch
5 times, most recently
from
c85dd0c
to
85d8186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements S3 multi-part upload/glob.
Information about s3 multi-part upload API can be found: https://docs.aws.amazon.com/AmazonS3/latest/userguide/mpuoverview.html
Glob uses the s3 listobject api: https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectsV2.html