Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cast node, rel, recursive rel to string #2896

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@andyfengHKU andyfengHKU marked this pull request as ready for review February 15, 2024 16:03
@andyfengHKU andyfengHKU changed the title Fix cast node, rel, recursive to string Fix cast node, rel, recursive rel to string Feb 15, 2024
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6283aa5) 93.41% compared to head (a7d6344) 93.41%.

Files Patch % Lines
src/common/type_utils.cpp 94.54% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2896   +/-   ##
=======================================
  Coverage   93.41%   93.41%           
=======================================
  Files        1100     1100           
  Lines       42352    42382   +30     
=======================================
+ Hits        39563    39593   +30     
  Misses       2789     2789           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit 6b739d9 into master Feb 16, 2024
15 checks passed
@andyfengHKU andyfengHKU deleted the fix-export-path branch February 16, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants