Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address #2954 for C++, C, Python, Node.js, and Java APIs #2958

Merged
merged 10 commits into from
Feb 28, 2024
Merged

Conversation

mewim
Copy link
Member

@mewim mewim commented Feb 27, 2024

No description provided.

@mewim mewim linked an issue Feb 27, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.53%. Comparing base (ea4b95b) to head (2765bb3).

Files Patch % Lines
tools/java_api/src/jni/kuzu_java.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2958   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files        1117     1119    +2     
  Lines       42925    42951   +26     
=======================================
+ Hits        40149    40175   +26     
  Misses       2776     2776           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mewim mewim requested a review from ray6080 February 27, 2024 15:01
@mewim mewim changed the title Address #2954 Address #2954 for C++, C, Python, Node.js, and Java APIs Feb 27, 2024
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mewim mewim merged commit e056583 into master Feb 28, 2024
15 checks passed
@mewim mewim deleted the fix-2954 branch February 28, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants