Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Partitioner to use ChunkedNodeGroupCollection #3123

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Mar 23, 2024

  • move ChunkedNodeGroupCollection to separate files with a bit more append/merge interfaces.
  • refactor Partitioner to use ChunkedNodeGroupCollection.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 98.94737% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.91%. Comparing base (f9bc0c6) to head (0a10f6f).

Files Patch % Lines
...rc/processor/operator/persistent/index_builder.cpp 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3123      +/-   ##
==========================================
+ Coverage   91.89%   91.91%   +0.02%     
==========================================
  Files        1169     1171       +2     
  Lines       43774    43791      +17     
==========================================
+ Hits        40227    40252      +25     
+ Misses       3547     3539       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 365815b into master Mar 23, 2024
17 checks passed
@ray6080 ray6080 deleted the chunked-group-collection branch March 23, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants